Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4199#discussion_r124335359
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/MathFunctions.scala
 ---
    @@ -16,7 +16,7 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.functions.utils
    +package org.apache.flink.table.runtime.functions
    --- End diff --
    
    I suggest `MathFunctions`->`ScalarFunctions`. so that we can add all scalar 
functions in one file. and in the `...runtime.functions` package we have three 
file `ScalarFunctions`,`TableFunctions` and `AggFunctions`.Which in FLINK-6810 
plan to do. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to