Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4199#discussion_r124329598
  
    --- Diff: 
flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
 ---
    @@ -1900,7 +1900,7 @@ public void unparse(
                new SqlGroupFunction(SqlKind.TUMBLE, null,
                        OperandTypes.or(OperandTypes.DATETIME_INTERVAL,
                                OperandTypes.DATETIME_INTERVAL_TIME)) {
    -                   @Override List<SqlGroupFunction> 
getAuxiliaryFunctions() {
    +                   @Override public List<SqlGroupFunction> 
getAuxiliaryFunctions() {
    --- End diff --
    
    Dose this method only using in `SqlStdOperatorTable.java`? if so , why we 
add `public`. I find calcite have not add this modifier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to