[
https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083658#comment-16083658
]
ASF GitHub Bot commented on FLINK-7100:
---------------------------------------
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4307
[FLINK-7100] TaskManager metrics are registered twice
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-7100
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4307
----
commit 88d69b3fbf7ef0aca22de3785319037b3a6ebddb
Author: zjureel <zjur...@gmail.com>
Date: 2017-07-12T08:25:24Z
remove registration of metric when associate with JM
commit a4cd8c5dfd9fadf34e3ec82f8ffab731ebc156c9
Author: zjureel <zjur...@gmail.com>
Date: 2017-07-12T08:33:46Z
Use MetricUtils instead of TaskExecutorMetricsInitializer and remove
TaskExecutorMetricsInitializer
----
> TaskManager metrics are registered twice
> ----------------------------------------
>
> Key: FLINK-7100
> URL: https://issues.apache.org/jira/browse/FLINK-7100
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime, Metrics
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Labels: flip-6
> Fix For: 1.4.0, 1.3.2
>
>
> TaskManager metrics are currently registered twice, once when the TaskManager
> is started and once when the TaskManager associates with a JobManager.
> Originally the metrics were registered when the TM associates with the JM and
> unregistered upon disassociation.
> 9e9776f17ed18b12af177e31ab0bc266236f85ef modified the {{TaskManager}} to use
> the {{TaskManagerServices}}, which when loaded _also_ register the metrics.
> I suggest to remove the registrations that happen upon (dis-)association.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
