[
https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085234#comment-16085234
]
ASF GitHub Bot commented on FLINK-7100:
---------------------------------------
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4307
@zentol Thank you for your review, I have fix the problems you metioned as
follows:
1. rename `TaskExecutorMetricsInitializer` to `MetricUtils`
2. move `taskManagerMetricGroup.close()` from `disassociateFromJobManager`
to `postStop`, I think the it's neccessary to close `taskManagerMetricGroup`
manually
Please have another look when you are free, thanks
> TaskManager metrics are registered twice
> ----------------------------------------
>
> Key: FLINK-7100
> URL: https://issues.apache.org/jira/browse/FLINK-7100
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime, Metrics
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Labels: flip-6
> Fix For: 1.4.0, 1.3.2
>
>
> TaskManager metrics are currently registered twice, once when the TaskManager
> is started and once when the TaskManager associates with a JobManager.
> Originally the metrics were registered when the TM associates with the JM and
> unregistered upon disassociation.
> 9e9776f17ed18b12af177e31ab0bc266236f85ef modified the {{TaskManager}} to use
> the {{TaskManagerServices}}, which when loaded _also_ register the metrics.
> I suggest to remove the registrations that happen upon (dis-)association.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
