[
https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087859#comment-16087859
]
ASF GitHub Bot commented on FLINK-7197:
---------------------------------------
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4345#discussion_r127532176
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java
---
@@ -56,7 +56,9 @@ public TranslateGraphIds(TranslateFunction<OLD, NEW>
translator) {
@Override
protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase
other) {
- super.mergeConfiguration(other);
+ if (!super.canMergeConfigurationWith(other)) {
--- End diff --
mergeConfiguration() wouldn't be called this way.
Is that intended ?
> Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
> ----------------------------------------------------------------------
>
> Key: FLINK-7197
> URL: https://issues.apache.org/jira/browse/FLINK-7197
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Greg Hogan
> Priority: Minor
>
> In
> flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateVertexValues.java
> :
> {code}
> protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase
> other) {
> super.mergeConfiguration(other);
> {code}
> GraphAlgorithmWrappingBase#canMergeConfigurationWith() should be called.
> There is similar issue in TranslateGraphIds.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
