[ 
https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092408#comment-16092408
 ] 

ASF GitHub Bot commented on FLINK-7197:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4345
  
    @tedyu does this look right to you now?


> Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
> ----------------------------------------------------------------------
>
>                 Key: FLINK-7197
>                 URL: https://issues.apache.org/jira/browse/FLINK-7197
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>            Reporter: Ted Yu
>            Assignee: Greg Hogan
>            Priority: Minor
>
> In 
> flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateVertexValues.java
>  :
> {code}
>   protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase 
> other) {
>     super.mergeConfiguration(other);
> {code}
> GraphAlgorithmWrappingBase#canMergeConfigurationWith() should be called.
> There is similar issue in TranslateGraphIds.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to