[ 
https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099710#comment-16099710
 ] 

ASF GitHub Bot commented on FLINK-6429:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r129240196
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/CorrelateTest.scala
 ---
    @@ -43,7 +43,7 @@ class CorrelateTest extends TableTestBase {
             term("invocation", "func1($cor0.c)"),
             term("function", func1.getClass.getCanonicalName),
             term("rowType",
    -             "RecordType(INTEGER a, BIGINT b, VARCHAR(2147483647) c, 
VARCHAR(2147483647) f0)"),
    +             "RecordType(INTEGER a, BIGINT b, VARCHAR(65536) c, 
VARCHAR(65536) f0)"),
    --- End diff --
    
    It seems that Calcite has defined an upper limit for strings and ignores 
our size. Can you also update this in `FlinkTypeSystem` and the comment in 
`FlinkTypeFactory#createSqlType`?


> Bump up Calcite version to 1.13
> -------------------------------
>
>                 Key: FLINK-6429
>                 URL: https://issues.apache.org/jira/browse/FLINK-6429
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Haohui Mai
>
> This is an umbrella issue for all tasks that need to be done once Apache 
> Calcite 1.13 is released.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to