[ 
https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110613#comment-16110613
 ] 

ASF GitHub Bot commented on FLINK-6429:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r130827249
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
 ---
    @@ -55,12 +55,13 @@ class JoinTest extends TableTestBase {
               unaryNode(
                 "DataStreamCalc",
                 streamTableNode(1),
    -            term("select", "a", "b", "proctime")
    +            term("select", "a", "b", "-(proctime, 3600000) AS -",
    --- End diff --
    
    Yes, I'm also curious why this plan would be generated. AFAIK, the 
`DataStreamWindowJoin` is very strict about the join predicates it accepts. It 
needs two range predicates with time indicator attributes on both sides. If the 
computation is pushed into the `DataStreamCalc` the time indicator attribute 
should be materialized and no longer be identified as a time indicator. 


> Bump up Calcite version to 1.13
> -------------------------------
>
>                 Key: FLINK-6429
>                 URL: https://issues.apache.org/jira/browse/FLINK-6429
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Haohui Mai
>
> This is an umbrella issue for all tasks that need to be done once Apache 
> Calcite 1.13 is released.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to