[ 
https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113850#comment-16113850
 ] 

ASF GitHub Bot commented on FLINK-6429:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r131302891
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
 ---
    @@ -55,12 +55,13 @@ class JoinTest extends TableTestBase {
               unaryNode(
                 "DataStreamCalc",
                 streamTableNode(1),
    -            term("select", "a", "b", "proctime")
    +            term("select", "a", "b", "-(proctime, 3600000) AS -",
    --- End diff --
    
    I think it's easy to prevent the time indicator push-down in our side. 
Calcite 1.3 changed the `ProjectJoinTransposeRule.INSTANCE` to `new 
ProjectJoinTransposeRule(         PushProjector.ExprCondition.TRUE, 
RelFactories.LOGICAL_BUILDER);` instead of `new 
ProjectJoinTransposeRule(PushProjector.ExprCondition.FALSE, 
RelFactories.LOGICAL_BUILDER);`.  
    
    In order to change the default behavior of the rule, the only thing we need 
to do is to create a new `ProjectJoinTransposeRule` with a custom 
`PushProjector.ExprCondition` which filters prevent time indicator rex nodes.


> Bump up Calcite version to 1.13
> -------------------------------
>
>                 Key: FLINK-6429
>                 URL: https://issues.apache.org/jira/browse/FLINK-6429
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Haohui Mai
>
> This is an umbrella issue for all tasks that need to be done once Apache 
> Calcite 1.13 is released.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to