Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4346#discussion_r132400996 --- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/EdgeListITCase.java --- @@ -56,214 +56,304 @@ public void testLongDescription() throws Exception { ProgramParametrizationException.class); } + // CirculantGraph + + private String[] getCirculantGraphParamters(String output) { + return parameters("CirculantGraph", output, "--vertex_count", "42", "--range0", "13:4"); + } + @Test public void testHashWithCirculantGraph() throws Exception { - expectedChecksum( - parameters("CirculantGraph", "hash", "--vertex_count", "42", "--range0", "13:4"), - 168, 0x000000000001ae80); + expectedChecksum(getCirculantGraphParamters("hash"), 168, 0x000000000001ae80); } @Test public void testPrintWithCirculantGraph() throws Exception { // skip 'char' since it is not printed as a number Assume.assumeFalse(idType.equals("char") || idType.equals("nativeChar")); - expectedOutputChecksum( - parameters("CirculantGraph", "print", "--vertex_count", "42", "--range0", "13:4"), - new Checksum(168, 0x0000004bdcc52cbcL)); + expectedOutputChecksum(getCirculantGraphParamters("print"), new Checksum(168, 0x0000004bdcc52cbcL)); + } + + @Test + public void testParallelismWithCirculantGraph() throws Exception { + TestUtils.verifyParallelism(getCirculantGraphParamters("print")); + } + + // CompleteGraph + + private String[] getCompleteGraphParamters(String output) { + return parameters("CompleteGraph", output, "--vertex_count", "42"); } @Test public void testHashWithCompleteGraph() throws Exception { - expectedChecksum( - parameters("CompleteGraph", "hash", "--vertex_count", "42"), - 1722, 0x0000000000113ca0L); + expectedChecksum(getCompleteGraphParamters("hash"), 1722, 0x0000000000113ca0L); } @Test public void testPrintWithCompleteGraph() throws Exception { // skip 'char' since it is not printed as a number Assume.assumeFalse(idType.equals("char") || idType.equals("nativeChar")); - expectedOutputChecksum( - parameters("CompleteGraph", "print", "--vertex_count", "42"), - new Checksum(1722, 0x0000031109a0c398L)); + expectedOutputChecksum(getCompleteGraphParamters("print"), new Checksum(1722, 0x0000031109a0c398L)); + } + + @Test + public void testParallelismWithCompleteGraph() throws Exception { + TestUtils.verifyParallelism(getCompleteGraphParamters("print")); + } + + // CycleGraph + + private String[] getCycleGraphParamters(String output) { + return parameters("CycleGraph", output, "--vertex_count", "42"); } @Test public void testHashWithCycleGraph() throws Exception { - expectedChecksum( - parameters("CycleGraph", "hash", "--vertex_count", "42"), - 84, 0x000000000000d740L); + expectedChecksum(getCycleGraphParamters("hash"), 84, 0x000000000000d740L); } @Test public void testPrintWithCycleGraph() throws Exception { // skip 'char' since it is not printed as a number Assume.assumeFalse(idType.equals("char") || idType.equals("nativeChar")); - expectedOutputChecksum( - parameters("CycleGraph", "print", "--vertex_count", "42"), - new Checksum(84, 0x000000272a136fcaL)); + expectedOutputChecksum(getCycleGraphParamters("print"), new Checksum(84, 0x000000272a136fcaL)); + } + + @Test + public void testParallelismWithCycleGraph() throws Exception { + TestUtils.verifyParallelism(getCycleGraphParamters("print")); + } + + // EchoGraph + + private String[] getEchoGraphParamters(String output) { + return parameters("EchoGraph", output, "--vertex_count", "42", "--vertex_degree", "13"); } @Test public void testHashWithEchoGraph() throws Exception { - expectedChecksum( - parameters("EchoGraph", "hash", "--vertex_count", "42", "--vertex_degree", "13"), - 546, 0x0000000000057720L); + expectedChecksum(getEchoGraphParamters("hash"), 546, 0x0000000000057720L); } @Test public void testPrintWithEchoGraph() throws Exception { // skip 'char' since it is not printed as a number Assume.assumeFalse(idType.equals("char") || idType.equals("nativeChar")); - expectedOutputChecksum( - parameters("EchoGraph", "print", "--vertex_count", "42", "--vertex_degree", "13"), - new Checksum(546, 0x000000f7190b8fcaL)); + expectedOutputChecksum(getEchoGraphParamters("print"), new Checksum(546, 0x000000f7190b8fcaL)); + } + + @Test + public void testParallelismWithEchoGraph() throws Exception { + TestUtils.verifyParallelism(getEchoGraphParamters("print")); + } + + // EmptyGraph + + private String[] getEmptyGraphParamters(String output) { --- End diff -- and here: `getEmptyGraphParameters`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---