Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4346#discussion_r132402963 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/LongParameter.java --- @@ -52,16 +52,6 @@ public LongParameter(ParameterizedBase owner, String name) { public LongParameter setDefaultValue(long defaultValue) { super.setDefaultValue(defaultValue); - if (hasMinimumValue) { - Util.checkParameter(defaultValue >= minimumValue, - "Default value (" + defaultValue + ") must be greater than or equal to minimum (" + minimumValue + ")"); - } - - if (hasMaximumValue) { - Util.checkParameter(defaultValue <= maximumValue, - "Default value (" + defaultValue + ") must be less than or equal to maximum (" + maximumValue + ")"); - } - --- End diff -- I'm no expert here, but can you elaborate on why you removed these checks for the default value being in line with the min and max? I can only guess that this must be that way in case where the default parallelism is not within the bounds of the configured one. I'm wondering whether the `LongParameter` is used somewhere else were these bounds are expected to hold though.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---