Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4331#discussion_r132895280
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
 ---
    @@ -150,6 +160,29 @@ long getWindowTime() {
                }
     
                /**
    +            * Check pattern after match skip strategy.
    +            */
    --- End diff --
    
    Could this whole check go in the `Pattern` class? This will make the code 
clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to