Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r133091608
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -340,6 +362,65 @@ public void resetNFAChanged() {
return Tuple2.of(result, timeoutResult);
}
+ private void
discardComputationStatesAccordingToStrategy(Queue<ComputationState<T>>
computationStates,
+ Collection<Map<String, List<T>>> matchedResult,
AfterMatchSkipStrategy afterMatchSkipStrategy) {
+ Set<T> discardEvents = new HashSet<>();
+ switch(afterMatchSkipStrategy.getStrategy()) {
+ case SKIP_TO_LAST:
+ for (Map<String, List<T>> resultMap:
matchedResult) {
+ for (Map.Entry<String, List<T>>
keyMatches : resultMap.entrySet()) {
+ if
(keyMatches.getKey().equals(afterMatchSkipStrategy.getPatternName())) {
+
discardEvents.addAll(keyMatches.getValue().subList(0,
keyMatches.getValue().size() - 1));
+ break;
+ } else {
+
discardEvents.addAll(keyMatches.getValue());
+ }
+ }
+ }
+ break;
+ case SKIP_TO_FIRST:
+ for (Map<String, List<T>> resultMap:
matchedResult) {
+ for (Map.Entry<String, List<T>>
keyMatches : resultMap.entrySet()) {
+ if
(keyMatches.getKey().equals(afterMatchSkipStrategy.getPatternName())) {
+ break;
+ } else {
+
discardEvents.addAll(keyMatches.getValue());
+ }
+ }
+ }
+ break;
+ case SKIP_PAST_LAST_EVENT:
+ for (Map<String, List<T>> resultMap:
matchedResult) {
+ for (List<T> eventList:
resultMap.values()) {
+ discardEvents.addAll(eventList);
+ }
+ }
+ break;
+ }
+ if (!discardEvents.isEmpty()) {
+ List<ComputationState<T>> discardStates = new
ArrayList<>();
+ for (ComputationState<T> computationState :
computationStates) {
+ Map<String, List<T>> partialMatch =
extractCurrentMatches(computationState);
+ for (List<T> list: partialMatch.values()) {
+ for (T e: list) {
+ if (discardEvents.contains(e)) {
+ // discard the
computation state.
+
eventSharedBuffer.release(
+
NFAStateNameHandler.getOriginalNameFromInternal(
+
computationState.getState().getName()),
+
computationState.getEvent(),
+
computationState.getTimestamp(),
+
computationState.getCounter()
+ );
+
discardStates.add(computationState);
--- End diff --
Yes, you are right. Thanks for pointing it out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
