[
https://issues.apache.org/jira/browse/FLINK-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125791#comment-16125791
]
Stephan Ewen commented on FLINK-7444:
-------------------------------------
Is that possibly pre-mature optimization?
A fatal error handler blocking the main thread sounds permissible, because the
process will anyways not continue normally after that.
Also, direct calls have the advantage of succeeding better in fatal cases. An
OOM that cannot spawn a thread will not be reported if passed through an
executor.
Especially for the fatal error handler, I would actually suggest to explicitly
NOT send it through an executor.
> Make external calls non-blocking
> --------------------------------
>
> Key: FLINK-7444
> URL: https://issues.apache.org/jira/browse/FLINK-7444
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> All external calls from a {{RpcEndpoint}} can be potentially blocking, e.g.
> calls to the {{FatalErrorHandler}}. Therefore, I propose to make all these
> calls coming from the {{RpcEndpoint's}} main thread non-blocking by running
> them in an {{Executor}}. That way the main thread will never be blocked.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
