[ https://issues.apache.org/jira/browse/FLINK-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130133#comment-16130133 ]
Till Rohrmann commented on FLINK-7444: -------------------------------------- I agree that the {{FatalErrorHandler}} should be executed directly as you've said and I will change the PR accordingly. All other external calls (e.g. the {{OnCompletionActions}}), will remain being executed asynchronously since I think this is more bullet-proof. > Make external calls non-blocking > -------------------------------- > > Key: FLINK-7444 > URL: https://issues.apache.org/jira/browse/FLINK-7444 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination > Affects Versions: 1.4.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > > All external calls from a {{RpcEndpoint}} can be potentially blocking, e.g. > calls to the {{FatalErrorHandler}}. Therefore, I propose to make all these > calls coming from the {{RpcEndpoint's}} main thread non-blocking by running > them in an {{Executor}}. That way the main thread will never be blocked. -- This message was sent by Atlassian JIRA (v6.4.14#64029)