[ 
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132017#comment-16132017
 ] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user kaibozhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r133925176
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
 ---
    @@ -179,13 +214,19 @@ class AggregationCodeGenerator(
                    |      ${aggMapping(i)},
                    |      (${accTypes(i)}) accs.getField($i));""".stripMargin
               } else {
    +            val setDataView = if (accConfig.isDefined && 
accConfig.get.isUseState) {
    --- End diff --
    
    Yes, it make sense.


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to