[
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134785#comment-16134785
]
ASF GitHub Bot commented on FLINK-7206:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134153349
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -80,7 +82,8 @@ class AggregationCodeGenerator(
outputArity: Int,
needRetract: Boolean,
needMerge: Boolean,
- needReset: Boolean)
+ needReset: Boolean,
+ accConfig: Option[DataViewConfig])
--- End diff --
It seems that `accConfig` is always `Some(x)`, do we need the `Option`?
> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
> Key: FLINK-7206
> URL: https://issues.apache.org/jira/browse/FLINK-7206
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Kaibo Zhou
> Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
