[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134448#comment-16134448 ]
Jark Wu commented on FLINK-7446: -------------------------------- >From my perspective, I think TableSource should provide an interface to define >timestamp and watermark at the same time. The {{DefinedRowtimeAttribute}} is >not a good design. A TableSource is not come from a DataStream, it is >converted into DataStream, so that the timestamp and watermark should be >defined by the TableSource not the DataStream. "generate timestamps and watermarks and validate that field and extracted timestamp are the same" is the validation happens at runtime? If it is, I prefer the later one. > Support to define an existing field as the rowtime field for TableSource > ------------------------------------------------------------------------ > > Key: FLINK-7446 > URL: https://issues.apache.org/jira/browse/FLINK-7446 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Jark Wu > Assignee: Jark Wu > > Currently {{DefinedRowtimeAttribute}} can define an appended rowtime field > for a {{TableSource}}. But it would be helpful if we can support to define an > existing field as the rowtime field. Just like registering a DataStream, the > rowtime field can be appended but also can replace an existing field. -- This message was sent by Atlassian JIRA (v6.4.14#64029)