[ 
https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137358#comment-16137358
 ] 

Fabian Hueske commented on FLINK-7446:
--------------------------------------

I agree that the watermark generation for TableSource's should be reworked. 
However, I'm not sure if we will achieve that before the next release. 
If we want to support to define an event-time indicator as an existing field 
and want to be sure that the implementation of the {{TableSource}} is correct, 
we would have to compare the {{StreamRecord}} timestamp with the existing 
attribute at runtime for each record.

However, since {{TableSource}} is an interface for rather experienced users 
(rather DBA than DB user), I'd be fine to omit this safety check. 

In the long run I agree with [~xccui]. We should have a watermark generator 
interface that works on an existing field with built-in implementations for the 
common cases.

> Support to define an existing field as the rowtime field for TableSource
> ------------------------------------------------------------------------
>
>                 Key: FLINK-7446
>                 URL: https://issues.apache.org/jira/browse/FLINK-7446
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> Currently {{DefinedRowtimeAttribute}} can define an appended rowtime field 
> for a {{TableSource}}. But it would be helpful if we can support to define an 
> existing field as the rowtime field. Just like registering a DataStream, the 
> rowtime field can be appended but also can replace an existing field.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to