[
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141143#comment-16141143
]
ASF GitHub Bot commented on FLINK-7206:
---------------------------------------
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135181433
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -100,6 +108,17 @@ abstract class GeneratedAggregations extends Function {
* aggregated results
*/
def resetAccumulator(accumulators: Row)
+
+ /**
+ * Cleanup for the accumulators.
+ */
+ def cleanup()
+
+ /**
+ * Tear-down method for
[[org.apache.flink.table.functions.AggregateFunction]].
+ * It can be used for clean up work. By default, this method does
nothing.
+ */
+ def close()
--- End diff --
The close() method is corresponding to open method. And it will be called
when open was called before, e.g. ProcTimeUnboundedOver's close() method.
Otherwise, the udagg's close will not be called.
I modify the case testGroupAggregateWithStateBackend to test the close was
called.
what do you think?
> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
> Key: FLINK-7206
> URL: https://issues.apache.org/jira/browse/FLINK-7206
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Kaibo Zhou
> Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
