[
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143722#comment-16143722
]
ASF GitHub Bot commented on FLINK-7206:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4355
Hi @wuchong,
I think we don't need to call `open()` and `close()` in
`AggregateAggFunction`. `GeneratedAggregations` is an internal class which is
not exposed to users. It would be a bug in the translation logic if a
`GeneratedAggregations` which requires `open()` or `close()` would be passed to
a `AggregateAggFunction`. A user couldn't do anything to prevent this.
+1 for refactoring `AggregateCodeGenerator`.
> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
> Key: FLINK-7206
> URL: https://issues.apache.org/jira/browse/FLINK-7206
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Kaibo Zhou
> Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
