Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138909210 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -64,7 +63,7 @@ * Buffer availability listeners, which need to be notified when a Buffer becomes available. * Listeners can only be registered at a time/state where no Buffer instance was available. */ - private final Queue<EventListener<Buffer>> registeredListeners = new ArrayDeque<EventListener<Buffer>>(); + private final Queue<BufferListener> registeredListeners = new ArrayDeque<>(); --- End diff -- I'd prefer to use `ArrayDeque` here for the member as well to help the JVM to optimise a bit (methods should mostly use less concrete types such as Queue to not limit users too much, but this is not necessary for a private member). I don't have strong feelings about this though.
---