Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4499#discussion_r136056467
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ---
    @@ -72,6 +79,21 @@
         */
        private int expectedSequenceNumber = 0;
     
    +   /** The initial number of exclusive buffers assigned to this channel. */
    +   private int initialCredit;
    +
    +   /** The current available exclusive buffers and requested floating 
buffers from buffer pool. */
    +   private final Queue<Buffer> availableBuffers = new ArrayDeque<>();
    --- End diff --
    
    I'd prefer to use `ArrayDeque` here for the member as well to help the JVM 
to optimise a bit (methods should mostly use less concrete types such as 
`Queue` to not limit users too much, but this is not necessary for a private 
member)


---

Reply via email to