[
https://issues.apache.org/jira/browse/FLINK-7813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208972#comment-16208972
]
ASF GitHub Bot commented on FLINK-7813:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4803#discussion_r145347968
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -402,25 +401,4 @@ public void run() {
}
}
}
-
- private static final class MetricRegistryThreadFactory implements
ThreadFactory {
- private final ThreadGroup group;
- private final AtomicInteger threadNumber = new AtomicInteger(1);
-
- MetricRegistryThreadFactory() {
- SecurityManager s = System.getSecurityManager();
- group = (s != null) ? s.getThreadGroup() :
Thread.currentThread().getThreadGroup();
- }
-
- public Thread newThread(Runnable r) {
- Thread t = new Thread(group, r, "Flink-MetricRegistry-"
+ threadNumber.getAndIncrement(), 0);
--- End diff --
That's true. It's not important imo; in fact I would argue that it's
actually an argument for merging it to make the names more consistent.
> Replace MetricRegistryThreadFactory
> -----------------------------------
>
> Key: FLINK-7813
> URL: https://issues.apache.org/jira/browse/FLINK-7813
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The MetricRegistry uses a custom ThreadFactory implementation to give threads
> names, whereas we could use the Flinks ExecutorThreadFactory instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
