[ https://issues.apache.org/jira/browse/FLINK-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219519#comment-16219519 ]
ASF GitHub Bot commented on FLINK-7840: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4827#discussion_r146986377 --- Diff: flink-runtime/pom.xml --- @@ -427,17 +427,42 @@ under the License. <goal>shade</goal> </goals> <configuration> + <!-- we need this to avoid having to specify all of akka's dependencies --> + <promoteTransitiveDependencies>true</promoteTransitiveDependencies> --- End diff -- Why exactly do we need this? AFAIK you can shade transitive dependencies without promoting them. > Shade Akka's Netty Dependency > ----------------------------- > > Key: FLINK-7840 > URL: https://issues.apache.org/jira/browse/FLINK-7840 > Project: Flink > Issue Type: Improvement > Components: Build System > Reporter: Stephan Ewen > Assignee: Stephan Ewen > Fix For: 1.4.0 > > > In order to avoid clashes between different Netty versions we should shade > Akka's Netty away. > These dependency version clashed manifest themselves in very subtle ways, > like occasional deadlocks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)