[
https://issues.apache.org/jira/browse/FLINK-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220205#comment-16220205
]
ASF GitHub Bot commented on FLINK-7840:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4827#discussion_r147088234
--- Diff: flink-test-utils-parent/flink-test-utils/pom.xml ---
@@ -117,6 +124,41 @@ under the License.
<inherited>true</inherited>
<extensions>true</extensions>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <includes
combine.children="append">
+
<include>io.netty:netty</include>
+ </includes>
+ </artifactSet>
+ <relocations
combine.children="append">
+ <relocation>
+
<pattern>org.jboss.netty</pattern>
+
<shadedPattern>org.apache.flink.shaded.testutils.org.jboss.netty</shadedPattern>
--- End diff --
Its not a transitive dependency, but a direct one. Test-utils depends on
netty directly for the network connection proxy. Because Netty clashes often
and such clashes have made tests unstable in a very subtle way, I wanted to
hide netty here again to avoid such future problems
> Shade Akka's Netty Dependency
> -----------------------------
>
> Key: FLINK-7840
> URL: https://issues.apache.org/jira/browse/FLINK-7840
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.4.0
>
>
> In order to avoid clashes between different Netty versions we should shade
> Akka's Netty away.
> These dependency version clashed manifest themselves in very subtle ways,
> like occasional deadlocks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
