[
https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274227#comment-16274227
]
ASF GitHub Bot commented on FLINK-8080:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154315071
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
@@ -25,20 +25,9 @@
public class MetricOptions {
/**
- * The list of named reporters. Names are defined here and per-reporter
configs
- * are given with the reporter config prefix and the reporter name.
- *
- * Example:
- * <pre>{@code
- * metrics.reporters = foo, bar
- *
- * metrics.reporter.foo.class =
org.apache.flink.metrics.reporter.JMXReporter
- * metrics.reporter.foo.interval = 10
- *
- * metrics.reporter.bar.class =
org.apache.flink.metrics.graphite.GraphiteReporter
- * metrics.reporter.bar.port = 1337
- * }</pre>
+ * @deprecated This configuration key has no effect.
*/
+ @Deprecated
--- End diff --
This option should only be used by Flink in the setup of reporters, and
tests/user-code to configure reporters. All these cases should continue to work
even with the option being a no-op. The only case that may now fail if some
test was configuring this option but no actual reporter, but well, that will
fail regardless of whether we keep the option or not.
I'd rather keep it to not cause compilation failures.
> Remove need for "metrics.reporters"
> -----------------------------------
>
> Key: FLINK-8080
> URL: https://issues.apache.org/jira/browse/FLINK-8080
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, Metrics
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.5.0
>
>
> Currently, in order to use a reporter one must configure something like this:
> {code}
> metrics.reporters: jmx
> metrics.reporter.jmx.class: ...
> {code}
> It would be neat if users did not have to set {{metrics.reporters}}. We can
> accomplish this by a scanning the configuration for configuration keys
> starting with {{metrics.reporter.}} and using the next word as a reporter
> name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
