[ 
https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285812#comment-16285812
 ] 

ASF GitHub Bot commented on FLINK-8080:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5099#discussion_r156052191
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -329,11 +329,11 @@ or by assigning unique names to jobs and operators.
     Metrics can be exposed to an external system by configuring one or several 
reporters in `conf/flink-conf.yaml`. These
     reporters will be instantiated on each job and task manager when they are 
started.
     
    -- `metrics.reporters`: The list of named reporters.
     - `metrics.reporter.<name>.<config>`: Generic setting `<config>` for the 
reporter named `<name>`.
     - `metrics.reporter.<name>.class`: The reporter class to use for the 
reporter named `<name>`.
     - `metrics.reporter.<name>.interval`: The reporter interval to use for the 
reporter named `<name>`.
     - `metrics.reporter.<name>.scope.delimiter`: The delimiter to use for the 
identifier (default value use `metrics.scope.delimiter`) for the reporter named 
`<name>`.
    +- `metrics.reporters`: (optional) An include list for reporters to 
instantiate. By default all configured reporters will be used.
    --- End diff --
    
    I guess it can't hurt to explicitly mention "comma-separated", but I don't 
have a strong preference, we have an example after all.


> Remove need for "metrics.reporters"
> -----------------------------------
>
>                 Key: FLINK-8080
>                 URL: https://issues.apache.org/jira/browse/FLINK-8080
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, Metrics
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> Currently, in order to use a reporter one must configure something like this:
> {code}
> metrics.reporters: jmx
> metrics.reporter.jmx.class: ...
> {code}
> It would be neat if users did not have to set {{metrics.reporters}}. We can 
> accomplish this by a scanning the configuration for configuration keys 
> starting with {{metrics.reporter.}} and using the next word as a reporter 
> name.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to