[ 
https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308212#comment-16308212
 ] 

ASF GitHub Bot commented on FLINK-8317:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5223#discussion_r159247245
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java ---
    @@ -27,11 +27,16 @@
     import java.util.concurrent.TimeoutException;
     
     /**
    - * Utility functions for Flink's RPC implementation
    + * Utility functions for Flink's RPC implementation.
      */
     public class RpcUtils {
     
    -   public static final Time INF_TIMEOUT = 
Time.milliseconds(Long.MAX_VALUE);
    +   /**
    +    * <b>HACK:</b> Set to 21474835 seconds, Akka's maximum delay (Akka 
2.4.20). The value cannot be
    +    * higher or an {@link IllegalArgumentException} will be thrown during 
an RPC. Check the private
    +    * method {@code checkMaxDelay()} in {@link 
akka.actor.LightArrayRevolverScheduler}.
    +    */
    +   public static final Time INF_TIMEOUT = 
Time.milliseconds(TimeUnit.SECONDS.toMillis(21474835));
    --- End diff --
    
    `Time.seconds(21474835)`


> Enable Triggering of Savepoints via RestfulGateway
> --------------------------------------------------
>
>                 Key: FLINK-8317
>                 URL: https://issues.apache.org/jira/browse/FLINK-8317
>             Project: Flink
>          Issue Type: New Feature
>          Components: Distributed Coordination, REST
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Enable triggering of savepoints in FLIP-6 mode via RestfulGateway:
> * Add method to {{CompletableFuture<CompletedCheckpoint> 
> triggerSavepoint(long timestamp, String targetDirectory)}} to interface
> * Implement method in {{Dispatcher}} and {{JobMaster}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to