[
https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324007#comment-16324007
]
ASF GitHub Bot commented on FLINK-8317:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161230839
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
---
@@ -137,4 +138,21 @@
JobID jobId, @RpcTimeout Time timeout) {
throw new UnsupportedOperationException();
}
+
+ /**
+ * Triggers a savepoint with the given savepoint directory as a target.
+ *
+ * @param targetDirectory Target directory for the savepoint.
+ * @param timeout for the asynchronous operation
+ * @return A future to the completed checkpoint
+ * @throws IllegalStateException If no savepoint directory has been
+ * specified and no default savepoint
directory has been
+ * configured
+ */
+ default CompletableFuture<CompletedCheckpoint> triggerSavepoint(
--- End diff --
I'm wondering whether we actually need to expose the `CompletedCheckpoint`.
Wouldn't it be enough to return the external path here? That way we would avoid
further coupling between external components and internal data structures.
> Enable Triggering of Savepoints via RestfulGateway
> --------------------------------------------------
>
> Key: FLINK-8317
> URL: https://issues.apache.org/jira/browse/FLINK-8317
> Project: Flink
> Issue Type: New Feature
> Components: Distributed Coordination, REST
> Affects Versions: 1.5.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Enable triggering of savepoints in FLIP-6 mode via RestfulGateway:
> * Add method to {{CompletableFuture<CompletedCheckpoint>
> triggerSavepoint(long timestamp, String targetDirectory)}} to
> {{RestfulGateway}} interface
> * Implement method in {{Dispatcher}} and {{JobMaster}}
> * Implement a new {{AbstractRestHandler}} which allows asynchronous
> triggering of savepoints
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
