[
https://issues.apache.org/jira/browse/FLINK-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341536#comment-16341536
]
ASF GitHub Bot commented on FLINK-8230:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/5373
[FLINK-8230] [orc] Fix NPEs when reading nested columns.
## What is the purpose of the change
- fixes NPEs for null-valued structs, lists, and maps
- fixes NPEs for repeating structs, lists, and maps
## Brief change log
- renamed `OrcUtils` to `OrcBatchReader`
- reimplement large parts of the `OrcBatchReader`
- add tests for nested columns with nulls and repeating values
- added a class to generate ORC files for tests
## Verifying this change
- added tests to `OrcInputFormatTest`
- changes have been verified by a user on a production dataset.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **n/a**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink orcNPE
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5373
----
commit 97fd0c7687eff6f8b84516f4d8ab8268cab838b1
Author: Fabian Hueske <fhueske@...>
Date: 2017-12-12T11:09:14Z
[FLINK-8230] [orc] Fix NPEs when reading nested columns.
- fixes NPEs for null-valued structs, lists, and maps
- fixes NPEs for repeating structs, lists, and maps
- adds test for deeply nested data with nulls
- adds test for columns with repeating values
----
> NPE in OrcRowInputFormat on nested structs
> ------------------------------------------
>
> Key: FLINK-8230
> URL: https://issues.apache.org/jira/browse/FLINK-8230
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats
> Affects Versions: 1.4.0
> Reporter: Sebastian Klemke
> Assignee: Fabian Hueske
> Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> OrcRowInputFormat ignores isNull and isRepeating on nested struct columns. If
> a struct column contains nulls, it tries to read struct fields, leading to
> NPE in case of string fields:
> {code}
> java.lang.NullPointerException
> at java.lang.String.checkBounds(String.java:384)
> at java.lang.String.<init>(String.java:462)
> at
> org.apache.flink.orc.OrcUtils.readNonNullBytesColumnAsString(OrcUtils.java:392)
> at org.apache.flink.orc.OrcUtils.readField(OrcUtils.java:215)
> at org.apache.flink.orc.OrcUtils.readStructColumn(OrcUtils.java:1203)
> at org.apache.flink.orc.OrcUtils.readField(OrcUtils.java:252)
> at
> org.apache.flink.orc.OrcUtils.readNonNullStructColumn(OrcUtils.java:677)
> at org.apache.flink.orc.OrcUtils.readField(OrcUtils.java:250)
> at org.apache.flink.orc.OrcUtils.fillRows(OrcUtils.java:142)
> at
> org.apache.flink.orc.OrcRowInputFormat.ensureBatch(OrcRowInputFormat.java:334)
> at
> org.apache.flink.orc.OrcRowInputFormat.reachedEnd(OrcRowInputFormat.java:314)
> at
> org.apache.flink.runtime.operators.DataSourceTask.invoke(DataSourceTask.java:165)
> at org.apache.flink.runtime.taskmanager.Task.run(Task.java:718)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
