Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/854#discussion_r33809780
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/CombineTaskTest.java
 ---
    @@ -92,7 +92,35 @@ public void testCombineTask() {
                
                this.outList.clear();
        }
    -   
    +
    +   @Test
    +   public void testOversizedRecordCombineTask() {
    +           int keyCnt = 1;
    +           int valCnt = 20;
    +
    +           addInput(new UniformRecordGenerator(keyCnt, valCnt, true));
    +           addDriverComparator(this.comparator);
    +           addDriverComparator(this.comparator);
    +           setOutput(this.outList);
    +
    +           
getTaskConfig().setDriverStrategy(DriverStrategy.SORTED_GROUP_COMBINE);
    +           getTaskConfig().setRelativeMemoryDriver(combine_frac);
    --- End diff --
    
    I think you cannot reduce the memory further below to enforce records to be 
oversized. I think you need to change the data generator to provide you with an 
oversized record. I think the tests have a `UnionIterator` where you can mix an 
oversized record into the generating iterator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to