Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/854#discussion_r34425008
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/GroupReduceCombineDriver.java
 ---
    @@ -170,7 +171,14 @@ public void run() throws Exception {
     
                        // write the value again
                        if (!this.sorter.write(value)) {
    -                           throw new IOException("Cannot write record to 
fresh sort buffer. Record too large.");
    +                           if (oversizedRecordCount == Long.MAX_VALUE) {
    --- End diff --
    
    I think we can skip this test. It's going to be very hard to process 2^63 
oversized records in a single Flink thread. Might take a millennium or so ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to