[
https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352634#comment-16352634
]
Xingcan Cui commented on FLINK-8538:
------------------------------------
Thanks for the explanation [~twalthr]. I've glanced over the PR for FLINK-8240
and tried to comprehend the work.
1. We are going to provide a unified interface, which is described by general
string properties, to define the table sources and sinks. Ideally, the users
can combine the descriptors (in different dimensions such as type, format, and
schema) to make their own table sources/sinks in the future, right?
2. Do you have any plans for how many table source/sink factories we are going
to support?
3. I got a feeling that we must do some refactorings for the existing
connectors since the source types and formats seem to be heavily coupled.
4. When mentioned {{format}} discovery, did you mean to implement different
{{FormatDescriptors}} and to match them just like using the {{SPI}} for the
{{TableSourceFactories}}?
I'd like to assist to implement the whole feature :) For now, maybe I can take
the {{CsvTableSourceFactory}} as a demo and imitate it to implement an
elementary {{KafkaTableSourceFactory}}.
What do you think?
> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>
> Key: FLINK-8538
> URL: https://issues.apache.org/jira/browse/FLINK-8538
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Xingcan Cui
> Priority: Major
>
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should
> be added. This issue includes improving the existing JSON descriptor with
> validation that can be used for other connectors as well. It is up for
> discussion if we want to split the KafkaJsonTableSource into connector and
> format such that we can reuse the format for other table sources as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
