[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355468#comment-16355468 ]
Xingcan Cui commented on FLINK-8538: ------------------------------------ Hi [~twalthr] and [~fhueske], it's still a question about the dependency. IMO, if we want to unify all the table source factories, they must be added to the {{SPI}} configuration file ({{META_INF/services/org.apache.flink.table.sources.TableSourceFactory}}), which is located in the {{flink-table}} subproject. That means the {{KafkaJsonTableSourceFactory}} in {{flink-kafka}} should also be registered here. Therefore a module cycle between {{flink-table}} and {{flink-kafka}} occurs. What do you think of that problem? > Add a Kafka table source factory with JSON format support > --------------------------------------------------------- > > Key: FLINK-8538 > URL: https://issues.apache.org/jira/browse/FLINK-8538 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Reporter: Timo Walther > Assignee: Xingcan Cui > Priority: Major > > Similar to CSVTableSourceFactory a Kafka table source factory for JSON should > be added. This issue includes improving the existing JSON descriptor with > validation that can be used for other connectors as well. It is up for > discussion if we want to split the KafkaJsonTableSource into connector and > format such that we can reuse the format for other table sources as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)