Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5403#discussion_r170260506
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -824,11 +814,8 @@ private void failPendingRequest(PendingRequest
pendingRequest, Exception e) {
}
@Nullable
- private SlotAndLocality pollAndAllocateSlot(
- SlotRequestId slotRequestId,
- ResourceProfile resourceProfile,
- Collection<TaskManagerLocation> locationPreferences) {
- SlotAndLocality slotFromPool =
availableSlots.poll(resourceProfile, locationPreferences);
+ private SlotAndLocality pollAndAllocateSlot(SlotRequestId
slotRequestId, SlotProfile slotProfile) {
--- End diff --
Would it be enough to pass in the `ProfileToSlotContextMatcher` instead of
the `SlotProfile`?
---
