Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5403#discussion_r170259983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -175,105 +176,17 @@ MultiTaskSlot createRootSlot(
* preferred locations is checked.
*
* @param groupId which the returned slot must not contain
- * @param locationPreferences specifying which locations are preferred
+ * @param matcher TODO
--- End diff --
Todo: Complete
---