[
https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374575#comment-16374575
]
ASF GitHub Bot commented on FLINK-8538:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170229924
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -89,37 +105,58 @@ class DescriptorProperties(normalizeKeys: Boolean =
true) {
put(key, clazz.getName)
}
+ /**
+ * Adds a string under the given key.
+ */
def putString(key: String, str: String): Unit = {
checkNotNull(key)
checkNotNull(str)
put(key, str)
}
+ /**
+ * Adds a boolean under the given key.
+ */
def putBoolean(key: String, b: Boolean): Unit = {
checkNotNull(key)
put(key, b.toString)
}
+ /**
+ * Adds a long under the given key.
+ */
def putLong(key: String, l: Long): Unit = {
checkNotNull(key)
put(key, l.toString)
}
+ /**
+ * Adds an integer under the given key.
+ */
def putInt(key: String, i: Int): Unit = {
checkNotNull(key)
put(key, i.toString)
}
+ /**
+ * Adds a character under the given key.
+ */
def putCharacter(key: String, c: Character): Unit = {
checkNotNull(key)
checkNotNull(c)
put(key, c.toString)
}
+ /**
+ * Adds a table schema under the given key.
+ */
def putTableSchema(key: String, schema: TableSchema): Unit = {
putTableSchema(key, normalizeTableSchema(schema))
}
+ /**
+ * Adds a table schema under the given key.
+ */
def putTableSchema(key: String, nameAndType: Seq[(String, String)]):
Unit = {
--- End diff --
Remove?
> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>
> Key: FLINK-8538
> URL: https://issues.apache.org/jira/browse/FLINK-8538
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Xingcan Cui
> Priority: Major
>
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should
> be added. This issue includes improving the existing JSON descriptor with
> validation that can be used for other connectors as well. It is up for
> discussion if we want to split the KafkaJsonTableSource into connector and
> format such that we can reuse the format for other table sources as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
