[
https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374594#comment-16374594
]
ASF GitHub Bot commented on FLINK-8538:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170296912
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/table/descriptors/JsonValidator.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.table.api.ValidationException;
+
+/**
+ * Validator for {@link Json}.
+ */
+public class JsonValidator extends FormatDescriptorValidator {
+
+ public static final String FORMAT_TYPE_VALUE = "json";
+ public static final String FORMAT_SCHEMA = "format.schema";
+ public static final String FORMAT_JSON_SCHEMA = "format.json-schema";
+ public static final String FORMAT_FAIL_ON_MISSING_FIELD =
"format.fail-on-missing-field";
+
+ @Override
+ public void validate(DescriptorProperties properties) {
+ super.validate(properties);
+ final boolean hasSchema = properties.containsKey(FORMAT_SCHEMA);
+ final boolean hasSchemaString =
properties.containsKey(FORMAT_JSON_SCHEMA);
+ if (hasSchema && hasSchemaString) {
+ throw new ValidationException("A definition of both a
schema and JSON schema is not allowed.");
+ } else if (!hasSchema && !hasSchemaString) {
+ throw new ValidationException("A definition of a schema
and JSON schema is required.");
--- End diff --
replace "and" by "or" -> "A definition of a schema or JSON schema is
required."
> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>
> Key: FLINK-8538
> URL: https://issues.apache.org/jira/browse/FLINK-8538
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Xingcan Cui
> Priority: Major
>
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should
> be added. This issue includes improving the existing JSON descriptor with
> validation that can be used for other connectors as well. It is up for
> discussion if we want to split the KafkaJsonTableSource into connector and
> format such that we can reuse the format for other table sources as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
