[
https://issues.apache.org/jira/browse/FLINK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383619#comment-16383619
]
ASF GitHub Bot commented on FLINK-8459:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5622#discussion_r171858158
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointTriggerRequestBodyTest.java
---
@@ -34,8 +34,8 @@
}
@Override
- protected SavepointTriggerRequestBody getTestRequestInstance() throws
Exception {
- return new SavepointTriggerRequestBody("/tmp");
+ protected SavepointTriggerRequestBody getTestRequestInstance() {
+ return new SavepointTriggerRequestBody("/tmp", true);
--- End diff --
strictly speaking the `false` case should be tested as well
> Implement cancelWithSavepoint in RestClusterClient
> --------------------------------------------------
>
> Key: FLINK-8459
> URL: https://issues.apache.org/jira/browse/FLINK-8459
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Implement the method
> {{RestClusterClient#cancelWithSavepoint(JobID jobId, @Nullable String
> savepointDirectory)}}.
> by either taking a savepoint and cancel the job separately, or by migrating
> the logic in {{JobCancellationWithSavepointHandlers}}. The former will have
> different semantics because the checkpoint scheduler is not stopped. Thus it
> is not guaranteed that there won't be additional checkpoints between the
> savepoint and the job cancelation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
