[
https://issues.apache.org/jira/browse/FLINK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383628#comment-16383628
]
ASF GitHub Bot commented on FLINK-8459:
---------------------------------------
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5565
@yanghua Thanks for your contribution but I am afraid to tell you that we
have changed our mind and decided that it is better not to allow checkpoints
between the savepoint and job cancelation.
#5622 already implements this.
cc: @tillrohrmann
> Implement cancelWithSavepoint in RestClusterClient
> --------------------------------------------------
>
> Key: FLINK-8459
> URL: https://issues.apache.org/jira/browse/FLINK-8459
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Implement the method
> {{RestClusterClient#cancelWithSavepoint(JobID jobId, @Nullable String
> savepointDirectory)}}.
> by either taking a savepoint and cancel the job separately, or by migrating
> the logic in {{JobCancellationWithSavepointHandlers}}. The former will have
> different semantics because the checkpoint scheduler is not stopped. Thus it
> is not guaranteed that there won't be additional checkpoints between the
> savepoint and the job cancelation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
