[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394002#comment-16394002
]
Hequn Cheng commented on FLINK-8690:
------------------------------------
Hi, we don't have to create a new logical RelNode. As I said in the design doc,
we can rename current FlinkLogicalAggregateConverter to
FlinkLogicalAggregateDataSetConverter and add another
FlinkLogicalAggregateDataStreamConverter which supports distinct aggregates.
Both FlinkLogicalAggregateDataSetConverter and
FlinkLogicalAggregateDataStreamConverter convert a LogicalAggregate to a
FlinkLogicalAggregate. This may be more neat. What do you think?
> Update logical rule set to generate FlinkLogicalAggregate explicitly allow
> distinct agg on DataStream
> -----------------------------------------------------------------------------------------------------
>
> Key: FLINK-8690
> URL: https://issues.apache.org/jira/browse/FLINK-8690
> Project: Flink
> Issue Type: Sub-task
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
>
> Currently, *FlinkLogicalAggregate / FlinkLogicalWindowAggregate* does not
> allow distinct aggregate.
> We are proposing to reuse distinct aggregate codegen work designed for
> *FlinkLogicalOverAggregate*, to support unbounded distinct aggregation on
> datastream as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
