[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394379#comment-16394379
]
Rong Rong commented on FLINK-8690:
----------------------------------
Thanks [~hequn8128] for the valuable feedback :-)
I did some research and came up with a change somewhat close to what you
expected. Please see:
https://github.com/walterddr/flink/commit/6c25d178e7acff57c598e70a8f4a2c0f3b74332e
I had a hard time trying to find a place to put the two different
LogicalAggregateConverter(s), so I put them separately in 2 different
LOGICAL_OPT_RULESET, for Stream and Batch each.
Any comments or suggestions are highly appreciated :-)
> Update logical rule set to generate FlinkLogicalAggregate explicitly allow
> distinct agg on DataStream
> -----------------------------------------------------------------------------------------------------
>
> Key: FLINK-8690
> URL: https://issues.apache.org/jira/browse/FLINK-8690
> Project: Flink
> Issue Type: Sub-task
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
>
> Currently, *FlinkLogicalAggregate / FlinkLogicalWindowAggregate* does not
> allow distinct aggregate.
> We are proposing to reuse distinct aggregate codegen work designed for
> *FlinkLogicalOverAggregate*, to support unbounded distinct aggregation on
> datastream as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
