[ 
https://issues.apache.org/jira/browse/FLINK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407601#comment-16407601
 ] 

Till Rohrmann commented on FLINK-9026:
--------------------------------------

I think it is often better to close/unregister resources in the scope where 
they have been opened/registered. This makes resource management much easier.

But then we should at least close the {{TaskManagerMetricGroup}} when the 
{{TaskExecutor}} is shut down.

> Unregister finished tasks from TaskManagerMetricGroup and close it
> ------------------------------------------------------------------
>
>                 Key: FLINK-9026
>                 URL: https://issues.apache.org/jira/browse/FLINK-9026
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Sihua Zhou
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> We should unregister {{Tasks}} from the {{TaskManagerMetricGroup}} when they 
> have reached a final state. Moreover, we should close the 
> {{TaskManagerMetricGroup}} either in the {{TaskExecutor#postStop}} method or 
> let the caller do this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to