[ https://issues.apache.org/jira/browse/FLINK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407696#comment-16407696 ]
ASF GitHub Bot commented on FLINK-9026: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5734#discussion_r176028213 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -265,7 +265,11 @@ class TaskManager( case t: Exception => log.error("FileCache did not shutdown properly.", t) } - taskManagerMetricGroup.close() + try { + taskManagerMetricGroup.close() --- End diff -- same as above > Unregister finished tasks from TaskManagerMetricGroup and close it > ------------------------------------------------------------------ > > Key: FLINK-9026 > URL: https://issues.apache.org/jira/browse/FLINK-9026 > Project: Flink > Issue Type: Bug > Components: Metrics > Affects Versions: 1.5.0, 1.6.0 > Reporter: Till Rohrmann > Assignee: Sihua Zhou > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > We should unregister {{Tasks}} from the {{TaskManagerMetricGroup}} when they > have reached a final state. Moreover, we should close the > {{TaskManagerMetricGroup}} either in the {{TaskExecutor#postStop}} method or > let the caller do this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)