[
https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415640#comment-16415640
]
ASF GitHub Bot commented on FLINK-9099:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5775
[FLINK-9099] Assign Execution to LogicalSlot when slot is assigned to
Execution
## What is the purpose of the change
In order to fail fast if an allocated slot is released by the SlotPool, we
assign the
Execution as payload to a LogicalSlot when the slot is assigned to the
Execution.
cc @GJL
## Verifying this change
- Added
`ExecutionGraphSchedulingTest#testSlotReleasingFailsSchedulingOperation`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixSchedulingDeadlock
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5775
----
----
> Failing allocated slots not noticed
> -----------------------------------
>
> Key: FLINK-9099
> URL: https://issues.apache.org/jira/browse/FLINK-9099
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: flip-6
> Fix For: 1.5.0
>
>
> When allocating slots for eager scheduling, it can happen that allocated
> slots get failed after they are assigned to the {{Execution}} (e.g. due to a
> {{TaskExecutor}} heartbeat timeout). If there are still some uncompleted slot
> futures, then this will not be noticed since the {{Execution}} is assigned to
> the {{LogicalSlot}} only after all slot futures are completed. Therefore, the
> allocated slot failure will go unnoticed until this happens.
> In order to speed up failures, we should directly assign the {{Execution}} to
> the {{LogicalSlot}} once the slot is assigned to the {{Execution}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
