[ 
https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416123#comment-16416123
 ] 

ASF GitHub Bot commented on FLINK-9099:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5775#discussion_r177543886
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
 ---
    @@ -659,7 +660,7 @@ public void disconnectResourceManager() {
                        .orTimeout(pendingRequest.getAllocatedSlotFuture(), 
allocationTimeout.toMilliseconds(), TimeUnit.MILLISECONDS)
                        .whenCompleteAsync(
                                (AllocatedSlot ignored, Throwable throwable) -> 
{
    -                                   if (throwable != null) {
    +                                   if (throwable instanceof 
TimeoutException) {
    --- End diff --
    
    Are we not losing some information by swallowing other types of exceptions?


> Failing allocated slots not noticed
> -----------------------------------
>
>                 Key: FLINK-9099
>                 URL: https://issues.apache.org/jira/browse/FLINK-9099
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> When allocating slots for eager scheduling, it can happen that allocated 
> slots get failed after they are assigned to the {{Execution}} (e.g. due to a 
> {{TaskExecutor}} heartbeat timeout). If there are still some uncompleted slot 
> futures, then this will not be noticed since the {{Execution}} is assigned to 
> the {{LogicalSlot}} only after all slot futures are completed. Therefore, the 
> allocated slot failure will go unnoticed until this happens.
> In order to speed up failures, we should directly assign the {{Execution}} to 
> the {{LogicalSlot}} once the slot is assigned to the {{Execution}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to