[
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458620#comment-16458620
]
ASF GitHub Bot commented on FLINK-8428:
---------------------------------------
Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/5327
@twalthr Hi, thanks for your review. I have updated the pr according to
your suggestions. Changes mainly include:
- Remove changes about UpsertSink
- Refactor test case name and add more test to cover code path
- Add more method comments
- Add another base class `NonWindowOuterJoinWithNonEquiPredicates` and move
corresponding variables and functions into it.
- Split `CRowWrappingMultiOutputCollector` into
`CRowWrappingMultiOutputCollector` and `LazyOutputCollector`.
Best, Hequn.
> Implement stream-stream non-window left outer join
> --------------------------------------------------
>
> Key: FLINK-8428
> URL: https://issues.apache.org/jira/browse/FLINK-8428
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
>
> Implement stream-stream non-window left outer join for sql/table-api. A
> simple design doc can be found
> [here|https://docs.google.com/document/d/1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=sharing]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
