[jira] [Commented] (FLINK-8428) Implement stream-stream non-window left outer join

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476992#comment-16476992
 ] 

ASF GitHub Bot commented on FLINK-8428:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5327#discussion_r188531694
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
 ---
    @@ -60,6 +60,9 @@ class DataStreamJoin(
     
       override def needsUpdatesAsRetraction: Boolean = true
     
    +  // outer join will generate retractions
    +  override def producesRetractions: Boolean = joinType != JoinRelType.INNER
    --- End diff --
    
    Thanks, now I understand the terminology between producing and just 
forwarding retractions.


> Implement stream-stream non-window left outer join
> --------------------------------------------------
>
>                 Key: FLINK-8428
>                 URL: https://issues.apache.org/jira/browse/FLINK-8428
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>
> Implement stream-stream non-window left outer join for sql/table-api. A 
> simple design doc can be found 
> [here|https://docs.google.com/document/d/1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=sharing]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)