Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5970#discussion_r187592909
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
    @@ -268,8 +274,8 @@ public void 
testForwardIntoNestedTupleWithVarAndModification() {
     
        @Test
        public void testForwardIntoTupleWithAssignment() {
    -           
compareAnalyzerResultWithAnnotationsSingleInput(MapFunction.class, Map14.class, 
"Tuple2<String,Integer>",
    -                           "Tuple2<String,String>");
    +           
compareAnalyzerResultWithAnnotationsSingleInput(MapFunction.class, Map14.class,
    +                   TypeInformation.of(new TypeHint<Tuple2<String, 
Integer>>(){}), TypeInformation.of(new TypeHint<Tuple2<String, String>>(){}));
    --- End diff --
    
    There is so much use of the types `Tuple2<String, Integer>>` and 
`Tuple2<String, String>`, it would make sense to factor these out into a static 
field and reference them from there.


---

Reply via email to